Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3888
to look at the new patch set (#2).
Change subject: IMPALA-3953: Add missing synchronization in KuduScanNode
......................................................................
IMPALA-3953: Add missing synchronization in KuduScanNode
Attempt to fix IMPALA-3953 which isn't reproducing locally
or consistently, but seems to fail occasionally on jenkins.
After a previous fix for IMPALA-3857, KuduScanNodeTest
TestLimitsAreEnforced (BE test) seems to occasionally race
shutting down after a scan with a limit, resulting in a
scanner thread taking a lock_ that isn't valid and crashing
the process. While I cannot reproduce the issue or a clear
cut culprit, my theory is that the change for IMPALA-3857
changed the timing of the shutdown and exposed an existing
race.
This change is an attempt to fix a race around the limit and
shutdown paths where synchronization was missing. I'm not
completely sure this is the fix, but it is a bug worth
fixing regardless.
Change-Id: I16be206c60a692d2a26d719de8cc45e859b06e97
---
M be/src/exec/kudu-scan-node.cc
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/88/3888/2
--
To view, visit http://gerrit.cloudera.org:8080/3888
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I16be206c60a692d2a26d719de8cc45e859b06e97
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <[email protected]>
Gerrit-Reviewer: Matthew Jacobs <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
