Henry Robinson has posted comments on this change. Change subject: IMPALA-3953: Add missing synchronization in KuduScanNode ......................................................................
Patch Set 2: Would it make sense to add a d'tor to KuduScanNode that just DCHECK(is_closed_) (or maybe even to ~ExecNode)? If there's a path where Close() is not called on an exec node that's a bad bug, per the comments on Close(). -- To view, visit http://gerrit.cloudera.org:8080/3888 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16be206c60a692d2a26d719de8cc45e859b06e97 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: No
