Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3953: Add missing synchronization in KuduScanNode ......................................................................
Patch Set 2: > I don't think that this fixes IMPALA-3953, but it seems like it's > worth doing anyway. As we discussed in person, there's a bit more context wasn't yet in the JIRA: I eventually was able to hack a jenkins job to get it to fail and then quickly gather the stack on the machine myself. The crash stack shows a ScannerThread calling into the ThreadResourceMgr to release the token, which then calls back into KuduScanNode's ThreadAvailableCb, and that's where it crashes trying to take the lock_. That leads me to believe the KuduScanNode was torn down improperly. I can't figure out how that could have happened (a few other things that look suspicious I've reasoned through), and this is the only related issue that affects the crash scenario. I agree it doesn't seem too promising, but worth a shot and I need to step away from this bug for some time. -- To view, visit http://gerrit.cloudera.org:8080/3888 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16be206c60a692d2a26d719de8cc45e859b06e97 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: No
