Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-3953: Fixes for KuduScanNode BE test failure ......................................................................
IMPALA-3953: Fixes for KuduScanNode BE test failure After a previous fix for IMPALA-3857, KuduScanNodeTest TestLimitsAreEnforced (BE test) occasionally throws when a scanner thread takes a lock_ that isn't valid, crashing the process. It looks like the issue is likely that TestScanEmptyString isn't closing its KuduScanNode, and a lingering ScannerThread may end up touching invalid memory later. This fixes the test case and also: 1) Adds some missing synchronization in KuduScanNode which was found in the process of investigating this issue. 2) Adds a DCHECK on ~KuduScanNode() to ensure it was closed. This was tested by running KuduScanNodeTest in a loop for 5 hours. Without the fix, the failure was produced within several hours. Change-Id: I16be206c60a692d2a26d719de8cc45e859b06e97 Reviewed-on: http://gerrit.cloudera.org:8080/3888 Reviewed-by: Tim Armstrong <[email protected]> Reviewed-by: Dan Hecht <[email protected]> Tested-by: Internal Jenkins --- M be/src/exec/kudu-scan-node-test.cc M be/src/exec/kudu-scan-node.cc 2 files changed, 4 insertions(+), 0 deletions(-) Approvals: Internal Jenkins: Verified Dan Hecht: Looks good to me, approved Tim Armstrong: Looks good to me, but someone else must approve -- To view, visit http://gerrit.cloudera.org:8080/3888 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I16be206c60a692d2a26d719de8cc45e859b06e97 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]>
