[GitHub] [jmeter] vlsi commented on a diff in pull request #5873: Add errorprone verifications

[via GitHub]

vlsi commented on code in PR #5873:
URL: https://github.com/apache/jmeter/pull/5873#discussion_r1181673953


##########
build-logic/verification/src/main/kotlin/build-logic.errorprone.gradle.kts:
##########
@@ -38,11 +38,28 @@ if (buildParameters.enableErrorprone) {
             // Ignore warnings in test code
             options.errorprone.isEnabled.set(false)
         } else {
+            // Errorprone requires Java 11+
+            options.errorprone.isEnabled.set(
+                javaCompiler.map { 
it.metadata.languageVersion.canCompileOrRun(11) }
+            )
             options.compilerArgs.addAll(listOf("-Xmaxerrs", "10000", 
"-Xmaxwarns", "10000"))
             options.errorprone {
                 disableWarningsInGeneratedCode.set(true)
                 enable(
-                    "PackageLocation"
+                    "MissingDefault",
+                    "PackageLocation",
+                    "RedundantOverride",
+                    "StronglyTypeTime",
+                    "UnescapedEntity",
+                    "UnnecessaryAnonymousClass",
+                    "UnnecessaryDefaultInEnumSwitch",
+                )
+                warn(
+                    // "FieldCanBeFinal",

Review Comment:
   fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org