vlsi commented on code in PR #5873:
URL: https://github.com/apache/jmeter/pull/5873#discussion_r1181645641
##########
src/core/src/main/java/org/apache/jmeter/report/processor/ExternalSampleSorter.java:
##########
@@ -91,9 +91,9 @@ public class ExternalSampleSorter extends
AbstractSampleConsumer {
private final BlockingQueue<Runnable> workQueue = new
LinkedBlockingQueue<>();
- private ThreadPoolExecutor pool;
+ private final ThreadPoolExecutor pool;
- private volatile int nbProcessors;
+ private final int nbProcessors;
Review Comment:
Same thing: the field is private, and it is initialized only in constructor.
So it can be safely made `final`.
It was IDEA that updated `volatile` -> `final` in `run inspection by name
...` -> `field may be final`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jmeter.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
