vlsi commented on code in PR #5873:
URL: https://github.com/apache/jmeter/pull/5873#discussion_r1181661242
##########
src/jorphan/src/main/java/org/apache/jorphan/gui/MenuScroller.java:
##########
@@ -514,19 +514,6 @@ public void dispose() {
}
}
- /**
- * Ensures that the <code>dispose</code> method of this MenuScroller is
- * called when there are no more references to it.
- *
- * @see MenuScroller#dispose()
- */
- @Override
- @SuppressWarnings("deprecation")
- public void finalize() throws Throwable {
- dispose();
Review Comment:
Finalize runs whenever the object becomes unreachable. Currently,
`MenuScroller` is discarded as soon as it is created. I believe this `finalize`
has never been useful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jmeter.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
