vlsi commented on code in PR #5873:
URL: https://github.com/apache/jmeter/pull/5873#discussion_r1181662643
##########
src/functions/src/main/java/org/apache/jmeter/functions/LogFunction.java:
##########
@@ -175,8 +175,6 @@ static synchronized void logDetails(Logger logger, String
stringToLog, String pr
case TRACE:
logger.trace("{} {} {}", threadName, separator,
stringToLog, throwable);
break;
- default:
Review Comment:
Do you really think we should protect from the case when
`org.slf4j.event.Level` enum will have extra enum value in runtime?
I think it would be unlikely, and if we drop the default, then we'll know
when slf4j adds new value in compile-time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jmeter.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
