[GitHub] [jmeter] vlsi commented on a diff in pull request #5873: Add errorprone verifications

[via GitHub]

vlsi commented on code in PR #5873:
URL: https://github.com/apache/jmeter/pull/5873#discussion_r1181662975


##########
src/protocol/http/src/main/java/org/apache/jmeter/protocol/http/proxy/ProxyControl.java:
##########
@@ -1532,8 +1532,6 @@ private void initKeyStore() throws IOException, 
GeneralSecurityException {
             break;
         case NONE:
             throw new IOException("Cannot find keytool application and no 
keystore was provided");
-        default:

Review Comment:
   This is switch over JMeter's enum:
   
   ```java
       public enum KeystoreMode {
           USER_KEYSTORE,   // user-provided keystore
           JMETER_KEYSTORE, // keystore generated by JMeter; single entry
           DYNAMIC_KEYSTORE,// keystore generated by JMeter; dynamic entries
           NONE             // cannot use keystore
       }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org