moresandeep commented on a change in pull request #143: KNOX-1997: Adding
changes to buffer messages from backend in onMessag…
URL: https://github.com/apache/knox/pull/143#discussion_r321794261
##########
File path:
gateway-server/src/main/java/org/apache/knox/gateway/websockets/ProxyWebSocketAdapter.java
##########
@@ -104,9 +114,33 @@ public void onWebSocketConnect(final Session
frontEndSession) {
throw new RuntimeIOException(e);
}
+ remoteLock.lock();
Review comment:
I don't like a locks here, can they be avoided, e.g. by using configurable
wait in `public void onMessageText(String message, Object session) {` not sure
if this is optimal, this is the first thing that came to my mind.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
