moresandeep commented on a change in pull request #143: KNOX-1997: Adding
changes to buffer messages from backend in onMessag…
URL: https://github.com/apache/knox/pull/143#discussion_r321797031
##########
File path:
gateway-server/src/main/java/org/apache/knox/gateway/websockets/ProxyWebSocketAdapter.java
##########
@@ -198,12 +232,29 @@ public void onError(Throwable cause) {
@Override
public void onMessageText(String message, Object session) {
+ LOG.logMessage("[From Backend <---]" + message);
+ remoteLock.lock();
Review comment:
Lock in a callback seems like a bad idea, especially the lock is dependent
on the creation of the front end session. Is there a way to avoid locks ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
