moresandeep commented on a change in pull request #143: KNOX-1997: Adding
changes to buffer messages from backend in onMessag…
URL: https://github.com/apache/knox/pull/143#discussion_r321801837
##########
File path:
gateway-server/src/main/java/org/apache/knox/gateway/websockets/ProxyWebSocketAdapter.java
##########
@@ -198,12 +232,29 @@ public void onError(Throwable cause) {
@Override
public void onMessageText(String message, Object session) {
+ LOG.logMessage("[From Backend <---]" + message);
+ remoteLock.lock();
final RemoteEndpoint remote = getRemote();
Review comment:
I prefer to avoid locks if they can be avoided. Instead of buffering can we
wait for a configurable amount of time to see if the remote object is created
before quitting ? This should not be an issue IMO since this should be on a
different thread than other connections.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
