moresandeep commented on a change in pull request #143: KNOX-1997: Adding
changes to buffer messages from backend in onMessag…
URL: https://github.com/apache/knox/pull/143#discussion_r321790316
##########
File path:
gateway-server/src/main/java/org/apache/knox/gateway/websockets/ProxyWebSocketAdapter.java
##########
@@ -104,9 +114,33 @@ public void onWebSocketConnect(final Session
frontEndSession) {
throw new RuntimeIOException(e);
}
+ remoteLock.lock();
super.onWebSocketConnect(frontEndSession);
this.frontendSession = frontEndSession;
+ final RemoteEndpoint remote = frontEndSession.getRemote();
+ try {
+ if (!messageBuffer.isEmpty()) {
+ LOG.logMessage("Found old buffered messages");
Review comment:
`LOG.logMessage` is for logging wesocket messages, for generic logging try
using a new function.
Please update it in other places. `LOG.logMessage` is a bad function name,
should have chosen something better :(
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
