----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45286/#review126292 -----------------------------------------------------------
lens-server-api/src/main/java/org/apache/lens/server/api/events/SchedulerAlarmEvent.java (line 48) <https://reviews.apache.org/r/45286/#comment189246> Is event id same as jobhandle? lens-server/src/main/java/org/apache/lens/server/scheduler/notification/services/AlarmService.java (line 83) <https://reviews.apache.org/r/45286/#comment189249> Should health status be changed in these cases? lens-server/src/main/java/org/apache/lens/server/scheduler/notification/services/AlarmService.java (line 97) <https://reviews.apache.org/r/45286/#comment189251> Can you doc about this method? Who/when will we call this method ? lens-server/src/main/java/org/apache/lens/server/scheduler/notification/services/AlarmService.java (line 111) <https://reviews.apache.org/r/45286/#comment189248> Should this be schedule name? - Amareshwari Sriramadasu On March 24, 2016, 2:09 p.m., Ajay Yadava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45286/ > ----------------------------------------------------------- > > (Updated March 24, 2016, 2:09 p.m.) > > > Review request for lens. > > > Bugs: LENS-987 > https://issues.apache.org/jira/browse/LENS-987 > > > Repository: lens > > > Description > ------- > > Alarm service will provide time notifications to the scheduler to trigger the > queries on a specified schedule. The schedule is built using the frequency. > > > Diffs > ----- > > lens-server-api/pom.xml 8304279 > > lens-server-api/src/main/java/org/apache/lens/server/api/events/SchedulerAlarmEvent.java > PRE-CREATION > lens-server/pom.xml 75b8b32 > lens-server/src/main/java/org/apache/lens/server/LensServices.java 48b3e00 > > lens-server/src/main/java/org/apache/lens/server/scheduler/notification/services/AlarmService.java > PRE-CREATION > > lens-server/src/test/java/org/apache/lens/server/scheduler/notification/services/AlarmServiceTest.java > PRE-CREATION > pom.xml 06cae12 > > Diff: https://reviews.apache.org/r/45286/diff/ > > > Testing > ------- > > > Thanks, > > Ajay Yadava > >
