----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45286/#review126715 -----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/scheduler/notification/services/AlarmService.java (line 65) <https://reviews.apache.org/r/45286/#comment189759> Looks like, service is not added to HealthCheckerRegistry. Can you add? lens-server/src/main/java/org/apache/lens/server/scheduler/notification/services/AlarmService.java (line 74) <https://reviews.apache.org/r/45286/#comment189760> Should we throw run time exception here instead of ignoring exception? I think at least we should change the health status to identify whether service is started or not. lens-server/src/main/java/org/apache/lens/server/scheduler/notification/services/AlarmService.java (line 83) <https://reviews.apache.org/r/45286/#comment189758> +1 for changing the health status for start() and init() failures - Raju Bairishetti On March 24, 2016, 2:09 p.m., Ajay Yadava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45286/ > ----------------------------------------------------------- > > (Updated March 24, 2016, 2:09 p.m.) > > > Review request for lens. > > > Bugs: LENS-987 > https://issues.apache.org/jira/browse/LENS-987 > > > Repository: lens > > > Description > ------- > > Alarm service will provide time notifications to the scheduler to trigger the > queries on a specified schedule. The schedule is built using the frequency. > > > Diffs > ----- > > lens-server-api/pom.xml 8304279 > > lens-server-api/src/main/java/org/apache/lens/server/api/events/SchedulerAlarmEvent.java > PRE-CREATION > lens-server/pom.xml 75b8b32 > lens-server/src/main/java/org/apache/lens/server/LensServices.java 48b3e00 > > lens-server/src/main/java/org/apache/lens/server/scheduler/notification/services/AlarmService.java > PRE-CREATION > > lens-server/src/test/java/org/apache/lens/server/scheduler/notification/services/AlarmServiceTest.java > PRE-CREATION > pom.xml 06cae12 > > Diff: https://reviews.apache.org/r/45286/diff/ > > > Testing > ------- > > > Thanks, > > Ajay Yadava > >
