> On March 31, 2016, 10:52 a.m., Amareshwari Sriramadasu wrote: > > lens-server/src/main/java/org/apache/lens/server/scheduler/notification/services/AlarmService.java, > > line 83 > > <https://reviews.apache.org/r/45286/diff/1/?file=1313701#file1313701line83> > > > > Should health status be changed in these cases?
Fixed. > On March 31, 2016, 10:52 a.m., Amareshwari Sriramadasu wrote: > > lens-server/src/main/java/org/apache/lens/server/scheduler/notification/services/AlarmService.java, > > line 97 > > <https://reviews.apache.org/r/45286/diff/1/?file=1313701#file1313701line97> > > > > Can you doc about this method? > > > > Who/when will we call this method ? Documented the required details. > On March 31, 2016, 10:52 a.m., Amareshwari Sriramadasu wrote: > > lens-server-api/src/main/java/org/apache/lens/server/api/events/SchedulerAlarmEvent.java, > > line 48 > > <https://reviews.apache.org/r/45286/diff/1/?file=1313698#file1313698line48> > > > > Is event id same as jobhandle? Yes, that is what I intended, do you see an issue with this approach? > On March 31, 2016, 10:52 a.m., Amareshwari Sriramadasu wrote: > > lens-server/src/main/java/org/apache/lens/server/scheduler/notification/services/AlarmService.java, > > line 111 > > <https://reviews.apache.org/r/45286/diff/1/?file=1313701#file1313701line111> > > > > Should this be schedule name? It does not matter. This is used by Quartz to group various requests across applications. To trace the origin and keep the service general I have renamed the group to "AlarmService". This will help in identifying from where the service was registered in case of multiple applications registering for triggers. - Ajay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45286/#review126292 ----------------------------------------------------------- On April 11, 2016, 8:44 a.m., Ajay Yadava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45286/ > ----------------------------------------------------------- > > (Updated April 11, 2016, 8:44 a.m.) > > > Review request for lens. > > > Bugs: LENS-987 > https://issues.apache.org/jira/browse/LENS-987 > > > Repository: lens > > > Description > ------- > > Alarm service will provide time notifications to the scheduler to trigger the > queries on a specified schedule. The schedule is built using the frequency. > > > Diffs > ----- > > lens-server-api/pom.xml 8304279 > > lens-server-api/src/main/java/org/apache/lens/server/api/events/SchedulerAlarmEvent.java > PRE-CREATION > lens-server/pom.xml 75b8b32 > lens-server/src/main/java/org/apache/lens/server/LensServices.java 48b3e00 > > lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java > 6852265 > > lens-server/src/main/java/org/apache/lens/server/scheduler/notification/services/AlarmService.java > PRE-CREATION > > lens-server/src/test/java/org/apache/lens/server/scheduler/notification/services/AlarmServiceTest.java > PRE-CREATION > pom.xml 309921f > > Diff: https://reviews.apache.org/r/45286/diff/ > > > Testing > ------- > > > Thanks, > > Ajay Yadava > >
