----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45286/#review128371 -----------------------------------------------------------
lens-server/pom.xml (line 235) <https://reviews.apache.org/r/45286/#comment191806> Please move the version definition to main pom's dependency management section lens-server/src/main/java/org/apache/lens/server/scheduler/notification/services/AlarmService.java (line 77) <https://reviews.apache.org/r/45286/#comment191807> Text seems wrong - Should say 'Alarm service' lens-server/src/test/java/org/apache/lens/server/scheduler/notification/services/AlarmServiceTest.java (line 90) <https://reviews.apache.org/r/45286/#comment191808> Starting all services but stopping only alarm service. Can you start only alarm service and event service, instead of starting all ? - Amareshwari Sriramadasu On April 11, 2016, 8:44 a.m., Ajay Yadava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45286/ > ----------------------------------------------------------- > > (Updated April 11, 2016, 8:44 a.m.) > > > Review request for lens. > > > Bugs: LENS-987 > https://issues.apache.org/jira/browse/LENS-987 > > > Repository: lens > > > Description > ------- > > Alarm service will provide time notifications to the scheduler to trigger the > queries on a specified schedule. The schedule is built using the frequency. > > > Diffs > ----- > > lens-server-api/pom.xml 8304279 > > lens-server-api/src/main/java/org/apache/lens/server/api/events/SchedulerAlarmEvent.java > PRE-CREATION > lens-server/pom.xml 75b8b32 > lens-server/src/main/java/org/apache/lens/server/LensServices.java 48b3e00 > > lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java > 6852265 > > lens-server/src/main/java/org/apache/lens/server/scheduler/notification/services/AlarmService.java > PRE-CREATION > > lens-server/src/test/java/org/apache/lens/server/scheduler/notification/services/AlarmServiceTest.java > PRE-CREATION > pom.xml 309921f > > Diff: https://reviews.apache.org/r/45286/diff/ > > > Testing > ------- > > > Thanks, > > Ajay Yadava > >
