> On April 3, 2016, 7:01 a.m., Raju Bairishetti wrote: > > lens-server/src/main/java/org/apache/lens/server/scheduler/notification/services/AlarmService.java, > > line 65 > > <https://reviews.apache.org/r/45286/diff/1/?file=1313701#file1313701line65> > > > > Looks like, service is not added to HealthCheckerRegistry. Can you add?
Ah, you are right! Thanks for catching it, fixed :) > On April 3, 2016, 7:01 a.m., Raju Bairishetti wrote: > > lens-server/src/main/java/org/apache/lens/server/scheduler/notification/services/AlarmService.java, > > line 74 > > <https://reviews.apache.org/r/45286/diff/1/?file=1313701#file1313701line74> > > > > Should we throw run time exception here instead of ignoring exception? > > > > I think at least we should change the health status to identify whether > > service is started or not. Updated the health status if the service fails to initialize. I am not sure about the side effects of throwing RuntimeException, if you feel that is the correct way to handle failures instead of changing the health status then please let me know and I will make changes accordingly. > On April 3, 2016, 7:01 a.m., Raju Bairishetti wrote: > > lens-server/src/main/java/org/apache/lens/server/scheduler/notification/services/AlarmService.java, > > line 83 > > <https://reviews.apache.org/r/45286/diff/1/?file=1313701#file1313701line83> > > > > +1 for changing the health status for start() and init() failures Done. - Ajay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45286/#review126715 ----------------------------------------------------------- On April 11, 2016, 8:44 a.m., Ajay Yadava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45286/ > ----------------------------------------------------------- > > (Updated April 11, 2016, 8:44 a.m.) > > > Review request for lens. > > > Bugs: LENS-987 > https://issues.apache.org/jira/browse/LENS-987 > > > Repository: lens > > > Description > ------- > > Alarm service will provide time notifications to the scheduler to trigger the > queries on a specified schedule. The schedule is built using the frequency. > > > Diffs > ----- > > lens-server-api/pom.xml 8304279 > > lens-server-api/src/main/java/org/apache/lens/server/api/events/SchedulerAlarmEvent.java > PRE-CREATION > lens-server/pom.xml 75b8b32 > lens-server/src/main/java/org/apache/lens/server/LensServices.java 48b3e00 > > lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java > 6852265 > > lens-server/src/main/java/org/apache/lens/server/scheduler/notification/services/AlarmService.java > PRE-CREATION > > lens-server/src/test/java/org/apache/lens/server/scheduler/notification/services/AlarmServiceTest.java > PRE-CREATION > pom.xml 309921f > > Diff: https://reviews.apache.org/r/45286/diff/ > > > Testing > ------- > > > Thanks, > > Ajay Yadava > >
