[
https://issues.apache.org/jira/browse/SOLR-8330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15020826#comment-15020826
]
Jason Gerlowski commented on SOLR-8330:
---------------------------------------
I'm fine w/ either approach, I don't have a strong opinion either way (as you
can probably tell by my earlier flip-flop).
But just for clarification, what's the advantage of having {{TransactionLog}}
on a message that comes from {{SubclassOfTLog}}. Under either approach,
someone investigating that message should be able to easily find it in any
modern IDE. Is it that {{TransactionLog}} is a more well-known piece of Solr
than an internal impl class, so readers would have a better notion of what's
going on than if the message was tagged {{TransactionLog}}?
Anyways, I can avoid touching the particular outer class-logger-used
in-inner-class scenarios exemplified by {{TransactionLog}} are there any other
cases I should be leaving as-is? I'm not sure how to infer intent vs.
accident/laziness in other scenarios unless there's an explicit comment
clarifying things, which I don't really expect there to be in many cases.
If I don't hear anything else in the next day I'll go forward based on the
feedback you guys've given so far.
> Remove unintentionally shared loggers.
> --------------------------------------
>
> Key: SOLR-8330
> URL: https://issues.apache.org/jira/browse/SOLR-8330
> Project: Solr
> Issue Type: Sub-task
> Affects Versions: Trunk
> Reporter: Jason Gerlowski
> Labels: logging
> Fix For: Trunk
>
>
> As Mike Drob pointed out in Solr-8324, many loggers in Solr are
> unintentionally shared between classes. Many instances of this are caused by
> overzealous copy-paste. This can make debugging tougher, as messages appear
> to come from an incorrect location.
> As discussed in the comments on SOLR-8324, there also might be legitimate
> reasons for sharing loggers between classes. Where any ambiguity exists,
> these instances shouldn't be touched.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
