[
https://issues.apache.org/jira/browse/SOLR-8330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15022761#comment-15022761
]
Anshum Gupta commented on SOLR-8330:
------------------------------------
>From how I understand this discussion, I think Mike and Mark are exactly on
>the same page and I agree with it. Here's what I think: All 'files' should use
>a single logger i.e. Inner classes reuse the logger but other than that, every
>class should have it's own logger. It'd make pointing at the file w.r.t the
>log entry easier and more obvious.
In any case, I think let's move forward with the least invasive approach and
get this resolved. We can always re-iterate in a manner that doesn't undo any
of the work done here so users don't have a hard time understanding and
adapting to the changes.
> Remove unintentionally shared loggers.
> --------------------------------------
>
> Key: SOLR-8330
> URL: https://issues.apache.org/jira/browse/SOLR-8330
> Project: Solr
> Issue Type: Sub-task
> Affects Versions: Trunk
> Reporter: Jason Gerlowski
> Labels: logging
> Fix For: Trunk
>
>
> As Mike Drob pointed out in Solr-8324, many loggers in Solr are
> unintentionally shared between classes. Many instances of this are caused by
> overzealous copy-paste. This can make debugging tougher, as messages appear
> to come from an incorrect location.
> As discussed in the comments on SOLR-8324, there also might be legitimate
> reasons for sharing loggers between classes. Where any ambiguity exists,
> these instances shouldn't be touched.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
