[
https://issues.apache.org/jira/browse/SOLR-8330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15022725#comment-15022725
]
Mike Drob commented on SOLR-8330:
---------------------------------
As somebody that looks at customer logs for the majority of my interaction with
Solr, I would want Loggers to correspond to file names every single time. So I
would actually prefer that inner classes use the outer class loggers, since
that makes the code in questions easiest to find. I know this conflicts minorly
with the initial stated goal, but I think it's a reasonable exception to make.
> Remove unintentionally shared loggers.
> --------------------------------------
>
> Key: SOLR-8330
> URL: https://issues.apache.org/jira/browse/SOLR-8330
> Project: Solr
> Issue Type: Sub-task
> Affects Versions: Trunk
> Reporter: Jason Gerlowski
> Labels: logging
> Fix For: Trunk
>
>
> As Mike Drob pointed out in Solr-8324, many loggers in Solr are
> unintentionally shared between classes. Many instances of this are caused by
> overzealous copy-paste. This can make debugging tougher, as messages appear
> to come from an incorrect location.
> As discussed in the comments on SOLR-8324, there also might be legitimate
> reasons for sharing loggers between classes. Where any ambiguity exists,
> these instances shouldn't be touched.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
