[
https://issues.apache.org/jira/browse/SOLR-8330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15021174#comment-15021174
]
Shawn Heisey commented on SOLR-8330:
------------------------------------
bq. We should simply comment those to protect them if there is no agreement.
Personally, I want the logs to point me to the correct class.
I'm with Mark on this. Someone who has no interest in the code won't know what
it means, but if they send the logs to someone who does have that interest
(including the mailing list or a Jira issue), then logging a different class
name will slow down efforts to help.
I can't think of a situation where a shared logger is actually a good idea, but
that might be a failure of imagination on my part. If there *IS* a good reason
to do it, that reason should definitely be in a comment on the logger creation.
> Remove unintentionally shared loggers.
> --------------------------------------
>
> Key: SOLR-8330
> URL: https://issues.apache.org/jira/browse/SOLR-8330
> Project: Solr
> Issue Type: Sub-task
> Affects Versions: Trunk
> Reporter: Jason Gerlowski
> Labels: logging
> Fix For: Trunk
>
>
> As Mike Drob pointed out in Solr-8324, many loggers in Solr are
> unintentionally shared between classes. Many instances of this are caused by
> overzealous copy-paste. This can make debugging tougher, as messages appear
> to come from an incorrect location.
> As discussed in the comments on SOLR-8324, there also might be legitimate
> reasons for sharing loggers between classes. Where any ambiguity exists,
> these instances shouldn't be touched.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
