[
https://issues.apache.org/jira/browse/SOLR-8330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15022757#comment-15022757
]
Mike Drob commented on SOLR-8330:
---------------------------------
I was imaging a hypothetical
{code}
class A {
static Logger logA = LoggerFactory.getLogger(A.class);
static class B {
static Logger logB = LoggerFactory.getLogger(B.class);
}
}
In that scenario, I would be in favor of removing {{logB}}, since there is no
corresponding {{B.java}} to look for and I'd have to deduce that it is in
{{A.java}}. Sometimes this is simple to figure out, sometimes not, most of the
time an IDE could find it but bash and vim need some more magic. If this is an
artifact of how I do development, then I'm not willing to make a big deal out
of it, but I figured it's worth mentioning it once.
> Remove unintentionally shared loggers.
> --------------------------------------
>
> Key: SOLR-8330
> URL: https://issues.apache.org/jira/browse/SOLR-8330
> Project: Solr
> Issue Type: Sub-task
> Affects Versions: Trunk
> Reporter: Jason Gerlowski
> Labels: logging
> Fix For: Trunk
>
>
> As Mike Drob pointed out in Solr-8324, many loggers in Solr are
> unintentionally shared between classes. Many instances of this are caused by
> overzealous copy-paste. This can make debugging tougher, as messages appear
> to come from an incorrect location.
> As discussed in the comments on SOLR-8324, there also might be legitimate
> reasons for sharing loggers between classes. Where any ambiguity exists,
> these instances shouldn't be touched.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
