[
https://issues.apache.org/jira/browse/SOLR-8330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15026940#comment-15026940
]
Shawn Heisey commented on SOLR-8330:
------------------------------------
I think it definitely is worthy of mention in CHANGES.txt, if only for the
sheer size of the patch. It's probably worth mentioning in the "upgrading
from" section as well as the issue list, with a paragraph similar to this:
{code}
* Logger declarations in most source files have changed to code that
no longer needs to explicitly state the class name. This fixes situations
where a logger for a different class was incorrectly used. See SOLR-8324
and its sub-issues for details.
{code}
On SOLR-8324, Uwe mentioned a way of doing the declaration without imports --
fully qualified class names in the code. I wonder if that's the way we should
do this. I have no strong opinion on the matter.
> Remove unintentionally shared loggers.
> --------------------------------------
>
> Key: SOLR-8330
> URL: https://issues.apache.org/jira/browse/SOLR-8330
> Project: Solr
> Issue Type: Sub-task
> Affects Versions: Trunk
> Reporter: Jason Gerlowski
> Labels: logging
> Fix For: Trunk
>
> Attachments: SOLR-8330.patch
>
>
> As Mike Drob pointed out in Solr-8324, many loggers in Solr are
> unintentionally shared between classes. Many instances of this are caused by
> overzealous copy-paste. This can make debugging tougher, as messages appear
> to come from an incorrect location.
> As discussed in the comments on SOLR-8324, there also might be legitimate
> reasons for sharing loggers between classes. Where any ambiguity exists,
> these instances shouldn't be touched.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
