[
https://issues.apache.org/jira/browse/SOLR-10912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16176500#comment-16176500
]
Cassandra Targett commented on SOLR-10912:
------------------------------------------
One thing I'd like to see added to validation is an indication when patches are
missing doc updates (i.e., the patch contains no edits to any .adoc file),
assuming that's possible.
I don't think the validation should fail if they are missing (so could be a
"-0", not impacting the final score), and some patches will not require doc
updates which would be hard to for such a tool to be able to determine. But, it
would help to ensure possible doc changes are considered at early stages of
patch review, and when changes are warranted they'd have a better chance of
being included before the final commit of the patch is done.
> Adding automatic patch validation
> ---------------------------------
>
> Key: SOLR-10912
> URL: https://issues.apache.org/jira/browse/SOLR-10912
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: Build
> Reporter: Mano Kovacs
> Attachments: SOLR-10912.sample-patch.patch,
> SOLR-10912.solj-contrib-facet-error.patch
>
>
> Proposing introduction of automated patch validation, similar what Hadoop or
> other Apache projects are using (see link). This would ensure that every
> patch passes a certain set of criterions before getting approved. It would
> save time for developer (faster feedback loop), save time for committers
> (less step to do manually), and would increase quality.
> Hadoop is currently using Apache Yetus to run validations, which seems to be
> a good direction to start. This jira could be the board of discussing the
> preferred solution.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
