[
https://issues.apache.org/jira/browse/SOLR-10912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16176532#comment-16176532
]
Christine Poerschke commented on SOLR-10912:
--------------------------------------------
bq. One thing I'd like to see added to validation is an indication when patches
are missing doc updates (i.e., the patch contains no edits to any .adoc file),
...
+1
bq. I don't think the validation should fail if they are missing ... some
patches will not require doc updates which would be hard to for such a tool to
be able to determine. ...
I agree, validation should not fail if doc updates are not (yet) present.
If doc updates are not (yet) present then it might also be nice for the tool to
try and point towards which parts of the documentation might need changing.
E.g. if the patch changes the {{ReplicationHandler.java}} class, the word
{{ReplicationHandler}} appears currently in three *.adoc files and the tool
could just mention them: implicit-requesthandlers.adoc index-replication.adoc
making-and-restoring-backups.adoc
> Adding automatic patch validation
> ---------------------------------
>
> Key: SOLR-10912
> URL: https://issues.apache.org/jira/browse/SOLR-10912
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: Build
> Reporter: Mano Kovacs
> Attachments: SOLR-10912.sample-patch.patch,
> SOLR-10912.solj-contrib-facet-error.patch
>
>
> Proposing introduction of automated patch validation, similar what Hadoop or
> other Apache projects are using (see link). This would ensure that every
> patch passes a certain set of criterions before getting approved. It would
> save time for developer (faster feedback loop), save time for committers
> (less step to do manually), and would increase quality.
> Hadoop is currently using Apache Yetus to run validations, which seems to be
> a good direction to start. This jira could be the board of discussing the
> preferred solution.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
