[
https://issues.apache.org/jira/browse/SOLR-10912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16189539#comment-16189539
]
Mano Kovacs commented on SOLR-10912:
------------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
00s{color} | {color:green} The patch does not contain any @author tags. {color}
|
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
00s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} Check examples refer correct lucene
version {color} | {color:green} 0m 07s{color} | {color:green} the patch passed
{color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} |
{color:green} 0m 07s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Check forbidden APIs {color} |
{color:green} 0m 07s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Check licenses {color} | {color:green}
0m 07s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 62m 41s{color}
| {color:red} core in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 11m 07s{color}
| {color:red} solrj in the patch passed. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 77m 37s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | solr.cloud.CdcrBootstrapTest |
| | solr.cloud.FullSolrCloudDistribCmdsTest |
| | solr.cloud.ReplaceNodeTest |
| | solr.cloud.TestCloudRecovery |
| | solr.cloud.TestLeaderElectionWithEmptyReplica |
| | solr.cloud.TestRebalanceLeaders |
| | solr.cloud.CdcrBootstrapTest |
| | solr.cloud.FullSolrCloudDistribCmdsTest |
| | solr.cloud.ReplaceNodeTest |
| | solr.cloud.TestCloudRecovery |
| | solr.cloud.TestLeaderElectionWithEmptyReplica |
| | solr.cloud.TestRebalanceLeaders |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | SOLR-10912 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12889953/SOLR-10912.ok-patch-in-core.patch
|
| Optional Tests | javac unit |
| uname | Darwin manomac.local 16.7.0 Darwin Kernel Version 16.7.0: Thu Jun 15
17:36:27 PDT 2017; root:xnu-3789.70.16~2/RELEASE_X86_64 x86_64 |
| Build tool | ant |
| Personality |
/Users/manokovacs/repos/solr-yetus/dev-tools/test-patch/solr-yetus-personality.sh
|
| git revision | master / fd2b4f3f86 |
| Default Java | 1.8.0_101 |
| unit | artifact/patchprocess/patch-unit-solr_core.txt |
| unit | artifact/patchprocess/patch-unit-solr_solrj.txt |
| modules | C: solr/core solr/solrj U: solr |
| Powered by | Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> Adding automatic patch validation
> ---------------------------------
>
> Key: SOLR-10912
> URL: https://issues.apache.org/jira/browse/SOLR-10912
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: Build
> Reporter: Mano Kovacs
> Attachments: SOLR-10912.ok-patch-in-core.patch,
> SOLR-10912.sample-patch.patch, SOLR-10912.solj-contrib-facet-error.patch
>
>
> Proposing introduction of automated patch validation, similar what Hadoop or
> other Apache projects are using (see link). This would ensure that every
> patch passes a certain set of criterions before getting approved. It would
> save time for developer (faster feedback loop), save time for committers
> (less step to do manually), and would increase quality.
> Hadoop is currently using Apache Yetus to run validations, which seems to be
> a good direction to start. This jira could be the board of discussing the
> preferred solution.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
