I'm also looking for someone who wants to help tackle javadoc and actually enabling our missing javadocs links check. I have some early stuff for that, some of it currently commented out:
https://github.com/apache/lucene-solr/blob/jira/SOLR-13452_gradle_5/build.gradle#L298 https://github.com/apache/lucene-solr/blob/jira/SOLR-13452_gradle_5/build.gradle#L87 Perhaps someone that knows a bit about our javadoc situation now? On Sun, Aug 25, 2019 at 6:31 PM Mark Miller <markrmil...@gmail.com> wrote: > No doubt there will be. Ensuring we have not lost too much in terms of > testing and quantifying what we have lost may be an area you are > comfortable with? > > I've done a loose attempt at passing in the right system properties and > what not, but some things have changed, some things may be missed (random > seed and random seed? I do have a start on that though! > https://github.com/apache/lucene-solr/blob/jira/SOLR-13452_gradle_5/buildSrc/common/configure-ext.gradle#L53), > some things can't be easily configured yet. > > We are using gradle to luanch tests and I love it cause it plays well with > gradle's max worker setting and launches tests across modules in parallel > nicely and works well with their pretty print output stuff, but they still > only have round robin garbage for distribution of tests across jvms. > Hopefully it catches up to what we had at some point - I'm not super keen > on trying to plug the ant launcher in instead myself, though I have > experimented with getting the junit 5 stuff working, thinking it's custom > engine separation stuff could be cool, but probably not that useful here it > turns out. > > Anyway, you probably have more experience with that stuff than me, so just > my current brain waves. > > > > On Sat, Aug 17, 2019 at 8:55 PM Dawid Weiss <dawid.we...@gmail.com> wrote: > >> >> I have some experience with Gradle too. I will try to help out if there >> is something I can do. >> >> Dawid >> >> On Sun, Aug 18, 2019, 09:40 Mark Miller <markrmil...@gmail.com> wrote: >> >>> I also would like to keep this overlap to a minimum. Ideally it would be >>> just enough time for devs to try things so we can fine tune any major rough >>> edges before removing things. >>> >>> The only reason it’s not my concrete plan is that it’s a little out of >>> my hands and will depend on when/if enough of us can handle churning though >>> through the switch to the teams satisfaction. I don’t expect all smooth >>> sailing. >>> >>> You are definitely a key piece to that equation, so that’s a start if >>> you are going to be ready. >>> >>> Mark >>> >>> On Fri, Aug 16, 2019 at 11:56 AM Uwe Schindler <u...@thetaphi.de> wrote: >>> >>>> Hi, >>>> >>>> >>>> >>>> I was talking with several people on berlinbuzzwords and we all agreed >>>> on one thing: Don’t keep the Ant, Maven and Gradle builds in parallel. >>>> IMHO, we should get rid of the Ant build ASAP, because it’s impossible to >>>> keep all three systems up to date at the same time. >>>> >>>> >>>> >>>> I think the reason for the parallel builds was to have it easier to >>>> merge when the new branch was created. In addition, I think Mark was afraid >>>> that some people will complain. But I think people will complain more, iff >>>> they have to maintain 3 build systems in parallel. >>>> >>>> >>>> >>>> In short: I’d like to get rid of the Ant/Maven build as soon as >>>> possible! I will also port over the Multirelease-JAR stuff in branch_8x, no >>>> worries! >>>> >>>> >>>> >>>> I am on vacation the next 2 weeks, so if you switch now, I can’t help >>>> with changing Jenkins. >>>> >>>> >>>> >>>> Uwe >>>> >>>> >>>> >>>> ----- >>>> >>>> Uwe Schindler >>>> >>>> Achterdiek 19, D-28357 Bremen >>>> <https://www.google.com/maps/search/Achterdiek+19,+D-28357+Bremen?entry=gmail&source=g> >>>> >>>> https://www.thetaphi.de >>>> >>>> eMail: u...@thetaphi.de >>>> >>>> >>>> >>>> *From:* Jan Høydahl <jan....@cominvent.com> >>>> *Sent:* Friday, August 16, 2019 11:34 AM >>>> *To:* dev@lucene.apache.org; markrmil...@gmail.com >>>> *Subject:* Re: The Gradle train. >>>> >>>> >>>> >>>> +1 >>>> >>>> >>>> >>>> Better to jump in now and have a few weeks of frustration and bug >>>> fixing from all of us than keeping this amazing improvement it a dark >>>> branch much longer :) >>>> >>>> I'll probably also try to adapt releaseWidard.py on master to work with >>>> the new build.. >>>> >>>> >>>> >>>> -- >>>> Jan Høydahl, search solution architect >>>> Cominvent AS - www.cominvent.com >>>> >>>> >>>> >>>> 15. aug. 2019 kl. 23:23 skrev Mark Miller <markrmil...@gmail.com>: >>>> >>>> >>>> >>>> https://issues.apache.org/jira/projects/SOLR/issues/SOLR-13452 Update >>>> the lucene-solr build from Ivy+Ant+Maven (shadow build) to Gradle. >>>> >>>> >>>> >>>> Okay, we are at the point where either this thing lands soon and gains >>>> some contributors to help finish or it overwhelms me and crashes & burns. >>>> That almost sounds negative, but it was actually the plan so far and I'm >>>> pretty excited after all this time invested. I need to punt this over to >>>> the community though - the final implications and ramifications of moving >>>> fully to gradle are just too big for me individually regardless of the time >>>> frame. >>>> >>>> >>>> >>>> I've done about 95%+ of what I wanted to do before trying to land >>>> something - a few more hoops to jump around. We pull in more deps than we >>>> should right now, I'll deal with that shortly, and mvn publishing needs >>>> work (mostly around solr-server, but dist and publishing both prob need >>>> edge work at least). Those are the main things on my mind. There are >>>> probably a ton of other little things, but I'm thinking those that are >>>> important will rise up quickly and the rest can be handled over time. >>>> >>>> >>>> >>>> This will be a large change. Some things will still take time to get up >>>> to par with what we have now. Many things will need to be sorted out >>>> (jenkins, releases, smoke tester type things, docs, etc). >>>> >>>> >>>> >>>> I've also made all the decisions and trade-offs and what not. I'm >>>> pretty happy about that, but I'm sure some will want to discuss and debate >>>> some choices once things are in their face. I've spent a lot of time in my >>>> recent life on this stuff and I'm ready to battle for some of it :) And to >>>> be mistaken, ignorant, or convinced of other paths for some other parts of >>>> it. I'll only say, every time I go from working with the gradle build back >>>> to ant+ivy+mvn, it feels like a big backslide. >>>> >>>> >>>> >>>> I'm thinking maybe in September/October? And only on master, hopefully >>>> living side by side with ant+ivy+mvn, but the goal would be for that period >>>> to be brief. They can't live in complete harmony - someone has to own the >>>> dependency view of the world for example, the one that actually gets >>>> committed (license, checksums, etc). Otherwise, I've done my best to do >>>> this in a way that doesn't break the current build. Will need to inspect >>>> that closer before landing though. >>>> >>>> >>>> >>>> This is just another heads up. Once we are in a main branch, I'm hoping >>>> a few of you will either have to jump in and help this land or we will have >>>> to pull it back out I think. Be prepared :) >>>> >>>> >>>> >>>> -- >>>> >>>> - Mark >>>> >>>> >>>> >>>> http://about.me/markrmiller >>>> >>>> >>>> >>> -- >>> - Mark >>> >>> http://about.me/markrmiller >>> >> > > -- > - Mark > > http://about.me/markrmiller > -- - Mark http://about.me/markrmiller
