[ 
https://issues.apache.org/jira/browse/LUCENE-3918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13591728#comment-13591728
 ] 

Shai Erera commented on LUCENE-3918:
------------------------------------

bq. patch with the other docvalues types too

Thanks Rob!

Indeed, I didn't separate between the ability to *sort by* other DocValues 
types, to reading them from an index, given some permutation on the docs. So 
now we have full support for reading such values from the index, given a 
permutation on the docs.

For sorting by such values, we offer for now only NumericDVSorter. Others can 
be added later on demand.

I think that in terms of the API and functionality, this is quite ready. 
However, we should beef up the tests .. for instance:

* Move to use newDirectory(), newIWC(), RandomIndexWriter etc. to incorporate 
some more randomness.
** I'm sure that most tests will fail since currently none seem to close the 
directory.
* Write some heavier tests which index random values to sort by (in different 
sources - payload, stored field ...), and lots of documents, to make sure our 
handling of the in-memory cached stuff works correctly.
* Write a test which creates a large index (few GBs) to make sure we're not 
limited to e.g. 2GB indexes while sorting ...

We don't need multi-threaded tests, as IndexSorter is not written for use in 
such scenarios.
                
> Port index sorter to trunk APIs
> -------------------------------
>
>                 Key: LUCENE-3918
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3918
>             Project: Lucene - Core
>          Issue Type: Task
>          Components: modules/other
>    Affects Versions: 4.0-ALPHA
>            Reporter: Robert Muir
>             Fix For: 4.2, 5.0
>
>         Attachments: LUCENE-3918.patch, LUCENE-3918.patch, LUCENE-3918.patch, 
> LUCENE-3918.patch, LUCENE-3918.patch, LUCENE-3918.patch, LUCENE-3918.patch
>
>
> LUCENE-2482 added an IndexSorter to 3.x, but we need to port this
> functionality to 4.0 apis.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to