Sorry, I've been meaning to get around to voting, but I didn't want to do a blind vote without actually taking the time to look at the packages and I have only now had the time to do so. The code is good, but I can't give a positive vote yet.
-1 RAT is showing several files that are missing licenses. I'll work on that right now and hopefully get something committed soon. Here are a few other things I found, relating to the root text files: CHANGES.TXT -- Minor, but on the first line (not yet released) should be removed from "3.0.3 trunk (not yet released)" -- Minor, a few lines down ArgumentOurOfRangeException should be ArgumentOutOfRangeException README.TXT -- Minor, we mention Lucene.NET is compiled against .NET 4.0, we should reword that to add in .NET 3.5 as well -- Under documentation, we are listing the 2.9.4 docs, whose API is significantly different from 3.0.3. It is also using the old incubator website -- Under additional libraries, a url is pointing to the old incubator svn repo and an old version (2.9.4) What is the plan on uploading the documentation? Changing those lines relies on where that documentation will be hosted. Thanks, Christopher On Thu, Oct 4, 2012 at 11:36 PM, Patric Forsgard <[email protected]> wrote: > Hi. > > I haven't work with the release but have used the alpha release and run all > our products unit-test with success result. > > So I will also give +1. > > // Patric > > > > On 5 October 2012 07:08, Simon Svensson <[email protected]> wrote: > >> I've realized from the answers since the first attempt that I have no clue >> about any Apache release formats. I can only vote on the general state of >> the code and functionality. I'll give it +1 to get it out to public >> consumption. >> >> >> On 2012-10-05 05:36, Prescott Nasser wrote: >> >>> So it's been more than 72 hours, we've technically had 3 +1's (myself, >>> Itamar and Simon). then Itamar to nit pick said -1 because of a minor >>> solution issue (which in my opinion doesn't require us to halt the release). >>> >>> I'm not particularly confident in our voting record on this one - could >>> anyone else chime in on the release artifacts? Should I cut a new release? >>> >>> Stefan, I know you're a bit busy but could you run ANT? (I think we are >>> pretty safe here) >>> >>> ~Prescott >>> >>> ------------------------------**---------- >>> >>>> From: [email protected] >>>> To: [email protected] >>>> Subject: [Vote] Apache Lucene.Net 3.0.3 Release >>>> Date: Fri, 28 Sep 2012 20:41:13 -0700 >>>> >>>> Alright, it's taken us a bit longer than we expected to get this up to >>>> vote. Thanks for everyone who helped out. This vote will be open for >>>> roughly 72 hours. >>>> >>>> +1 - Ready to roll >>>> 0 - don't care >>>> -1 - Not ready because... >>>> >>>> ~Prescott >>>> >>> >>
