Hello Jason, I do not know about Hervé, I checked out the gossip source to maybe add the needed documentation for configuring gossip, but found the Maven module structure, the code structure and the configuration format very confusing and after spending two hours to figure out how to easily handle my use case (I.e. do not log downloads in batch mode, output relative timestamp during Maven run) decided to delete it from the SNAPSHOT builds of 3.4.0 and replace it with slf4j-simple again, as in CI I do not need color that desperately but I don't like build logs spoiled with download messages. Same reason why I most of the times redirect output from surefire to files. When a test fails, the stack trace should normally give enough information to diagnose.
So I like the approach to stay with the trivial (monkey-patched) slf4j-simple. Regards Mirko -- Sent from my mobile Am 17.10.2016 13:49 schrieb "Jason van Zyl" <ja...@takari.io>: > So your approach was to fork some code, instead of trying to fix Gossip? I > haven’t been paying much attention just trying to understand why you would > fork instead of working with Jason Dillon to get that added? Did he not > respond or you couldn’t make a PR? > > Jason > > > On Oct 17, 2016, at 1:11 AM, Hervé BOUTEMY <herve.bout...@free.fr> > wrote: > > > > Hi Mirko, > > > > short answer: yes > > > > more precise answer: > > Gossip slf4j provider does not have color feature but has extensible > Renderer > > interface which permits to inject Maven colorized renderer [1] with one > > configuration line [2] > > > > In maven-slf4j-simple, I copied the same Maven colorized renderer code > [3] and > > injected it in slf4j simple through a Groovy script to patch slf4j simple > > source code [4]: not as straightforward than one fonciguration line, but > same > > effect with clean separation of Maven-specific extension code to support > > colorized output with Maven styles > > > > Regards, > > > > Hervé > > > > [1] https://github.com/apache/maven/blob/master/maven- > embedder/src/main/java/org/apache/maven/cli/logging/impl/ > gossip/ColorRenderer.java > > > > [2] https://github.com/apache/maven/blob/master/maven- > embedder/src/main/resources/META-INF/com.planet57.gossip/ > config.properties#L29 > > > > [3] https://github.com/apache/maven/blob/MNG-6093/maven- > slf4j-provider/src/main/java/org/slf4j/impl/MavenSimpleLogger.java > > > > [4] https://github.com/apache/maven/blob/MNG-6093/maven- > slf4j-provider/src/main/script/patch-slf4j-simple.groovy > > > > Le lundi 17 octobre 2016 07:00:50 Mirko Friedenhagen a écrit : > >> Hello Hervé, > >> > >> I would like a simple approach here. If I understand it correctly, > gossip > >> was chosen because of its color capability. If we could have this > without > >> switching the log provider it would be a good thing IMO. Gossip seems > to be > >> unconfigurable by means of system properties, which is a pity. > >> > >> Regards > >> Mirko > >> > >>> Jason Dillon started the Maven output color work by providing us a > Gossip > >>> slf4j provider renderer adapted to Maven context: thanks Jason > >>> > >>> Then current master uses Gossip slf4j provider by default with this > >>> customization. > >>> > >>> Given there were feedback from people finding the change disturbing vs > >>> usual > >>> slf4j simple provider (some are just about changing habits, some are > about > >>> missing features like logging configuration with CLI and relative > >>> timestamp), > >>> I tried another approach: patch slf4j simple provider to add > >>> Maven-specific > >>> rendering features. > >>> > >>> The result is available on MNG-6093 branch with maven-slf4j-provider > >>> module > >>> addition [1] > >>> > >>> I didn't really try to add features or extensions to slf4j Gossip. > >>> > >>> > >>> What is the best option for Maven: try to improve slf4j Gossip or use > this > >>> slf4j simple patched version? > >>> > >>> Regards, > >>> > >>> Hervé > >>> > >>> [1] https://github.com/apache/maven/tree/MNG-6093/maven-slf4j-provider > >>> > >>> > >>> --------------------------------------------------------------------- > >>> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > >>> For additional commands, e-mail: dev-h...@maven.apache.org > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > Thanks, > > Jason > > ---------------------------------------------------------- > Jason van Zyl > Founder, Takari and Apache Maven > http://twitter.com/jvanzyl > http://twitter.com/takari_io > --------------------------------------------------------- > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > >
