-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19176/
-----------------------------------------------------------
(Updated March 13, 2014, 11:27 p.m.)
Review request for mesos and Ben Mahler.
Changes
-------
It makes sense for bmahler to shepherd this since he's also working in the
master right now to integrate the registrar. -benh
Bugs: MESOS-905
https://issues.apache.org/jira/browse/MESOS-905
Repository: mesos-git
Description
-------
Eliminated the Framework.id FrameworkID field in master and slave, and replaced
each with a Framework.id() accessor that references Framework.FrameworkInfo.id.
Some messages (RunTaskMessage, ExecutorRegisteredMessage) will no longer need
the FrameworkID member, but it is 'required' and cannot be easily deprecated.
Due to rolling upgrades, we must (a) continue to set the FrameworkID in the
messages, in case the recipient is on an older version that needs it; and (b)
merge the FrameworkID into the FrameworkInfo.id, in case we are receiving a
message from an older sender.
Diffs
-----
src/master/http.cpp a019f15
src/master/master.hpp 49a3e15
src/master/master.cpp 2a40333
src/messages/messages.proto c26a3d0
src/slave/http.cpp 594032d
src/slave/slave.hpp 01b80df
src/slave/slave.cpp 6abb95d
Diff: https://reviews.apache.org/r/19176/diff/
Testing
-------
make check on ubuntu(Mint14)/gcc4.7.2.
Thanks,
Adam B
