-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19176/
-----------------------------------------------------------
(Updated March 20, 2014, 12:43 a.m.)
Review request for mesos and Ben Mahler.
Changes
-------
Rebased and removed redundant FrameworkID from
Allocator::frameworkAdded/frameworkActivated.
Bugs: MESOS-905
https://issues.apache.org/jira/browse/MESOS-905
Repository: mesos-git
Description (updated)
-------
Eliminated the Framework.id FrameworkID field in master and slave, and replaced
each with a Framework.id() accessor that references Framework.FrameworkInfo.id.
Removed redundant FrameworkID parameters when FrameworkInfo parameters also
exist with valid contained FrameworkID.
Some messages (RunTaskMessage, ExecutorRegisteredMessage) will no longer need
the FrameworkID member, but it is 'required' and cannot be easily deprecated.
Due to rolling upgrades, we must (a) continue to set the FrameworkID in the
messages, in case the recipient is on an older version that needs it; and (b)
merge the FrameworkID into the FrameworkInfo.id, in case we are receiving a
message from an older sender.
Diffs (updated)
-----
src/master/allocator.hpp 2e6a910
src/master/hierarchical_allocator_process.hpp 3ec453a
src/master/http.cpp 72d8e91
src/master/master.hpp 0c7c520
src/master/master.cpp 6da7766
src/messages/messages.proto c26a3d0
src/slave/http.cpp 594032d
src/slave/slave.hpp 01b80df
src/slave/slave.cpp d8d3e0f
src/tests/allocator_tests.cpp 31cc836
src/tests/allocator_zookeeper_tests.cpp 9ad0fa7
src/tests/mesos.hpp f77fbfe
src/tests/resource_offers_tests.cpp cf910e5
src/tests/slave_recovery_tests.cpp 40a9599
Diff: https://reviews.apache.org/r/19176/diff/
Testing
-------
make check on ubuntu(Mint14)/gcc4.7.2.
Thanks,
Adam B
