-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18957/
-----------------------------------------------------------
(Updated March 17, 2014, 3:16 p.m.)
Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Niklas Nielsen,
Timothy St. Clair, and Vinod Kone.
Changes
-------
Entirely revised.
Summary (updated)
-----------------
Added --enable-proper flag as well as its first implementation
--with-leveldb[=DIR]
Bugs: MESOS-1071
https://issues.apache.org/jira/browse/MESOS-1071
Repository: mesos-git
Description (updated)
-------
Allows preventing the use of bundled libraries in favor of preinstalled
versions, where possible.
--enable-proper generally switches from bundled to preinstalled libraries. This
review only implements this preinstalled library usage on LevelDB. For using
the preinstalled LevelDB from a location that is not part of the standard
include and linker paths, you may specify --with-leveldb=PREFIX_PATH.
If --enable-proper is supplied, the configuration phase will attempt to locate
the needed headers as well as the library itself.
If --enable-proper is not supplied, the bundled library is built and used.
NOTE: Subsequent review requests for other bundled libraries will follow as
soon as this implementation has been accepted.
Diffs (updated)
-----
3rdparty/Makefile.am 23ff1fa
configure.ac 9a6de87
src/Makefile.am 0775a0d
src/python/setup.py.in 02f00ef
Diff: https://reviews.apache.org/r/18957/diff/
Testing (updated)
-------
../configure
make check
installed leveldb in custom location
../configure --enable-proper --with-leveldb=/CUSTOM_LOCATION
make check
installed leveldb in common location
../configure --enable-proper
make check
Thanks,
Till Toenshoff
