----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18957/#review37383 -----------------------------------------------------------
Looks good, thanks for the patch! Some minor comments are below. configure.ac <https://reviews.apache.org/r/18957/#comment68897> Given that this block has the potential for becoming large it may be easier to read using 'if test' vs. AS_IF around 'enable_proper' configure.ac <https://reviews.apache.org/r/18957/#comment68898> I'm not certain the -lleveldb flag needs to be applied to all, or whether we can call out -lleveldb where needed? Previously, the linkage of .a's automatically did incremental, but if linking system .so's this could cause unused linkage on executable(s) that didn't actually use the library. - Timothy St. Clair On March 17, 2014, 3:16 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18957/ > ----------------------------------------------------------- > > (Updated March 17, 2014, 3:16 p.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Niklas > Nielsen, Timothy St. Clair, and Vinod Kone. > > > Bugs: MESOS-1071 > https://issues.apache.org/jira/browse/MESOS-1071 > > > Repository: mesos-git > > > Description > ------- > > Allows preventing the use of bundled libraries in favor of preinstalled > versions, where possible. > > --enable-proper generally switches from bundled to preinstalled libraries. > This review only implements this preinstalled library usage on LevelDB. For > using the preinstalled LevelDB from a location that is not part of the > standard include and linker paths, you may specify --with-leveldb=PREFIX_PATH. > > If --enable-proper is supplied, the configuration phase will attempt to > locate the needed headers as well as the library itself. > > If --enable-proper is not supplied, the bundled library is built and used. > > NOTE: Subsequent review requests for other bundled libraries will follow as > soon as this implementation has been accepted. > > > Diffs > ----- > > 3rdparty/Makefile.am 23ff1fa > configure.ac 9a6de87 > src/Makefile.am 0775a0d > src/python/setup.py.in 02f00ef > > Diff: https://reviews.apache.org/r/18957/diff/ > > > Testing > ------- > > ../configure > make check > > installed leveldb in custom location > ../configure --enable-proper --with-leveldb=/CUSTOM_LOCATION > make check > > installed leveldb in common location > ../configure --enable-proper > make check > > > Thanks, > > Till Toenshoff > >
