> On March 19, 2014, 12:42 a.m., Adam B wrote: > > How did we decide on "--enable-proper"? Why not --disable-bundled (or > > --disable-bundled-libs)? Or enable-preinstalled-libs? > > What parameters do I have to use to make it search for the preinstalled lib > > and fallback to bundled if it can't find it? > > What do I have to use to make it search for the preinstalled lib and fail > > if it can't find it? > > What do I have to use to make it use the preinstalled lib for the one (or > > more) that I specify and use bundled for the rest?
Thanks for the comment Adam. All the details are spelled out in the JIRA. Names don't really matter to me vs. behavior. If you have opinions, perhaps writing a case on https://issues.apache.org/jira/browse/MESOS-1071 might help. - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18957/#review37669 ----------------------------------------------------------- On March 17, 2014, 7:51 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18957/ > ----------------------------------------------------------- > > (Updated March 17, 2014, 7:51 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Bugs: MESOS-1071 > https://issues.apache.org/jira/browse/MESOS-1071 > > > Repository: mesos-git > > > Description > ------- > > Allows preventing the use of bundled libraries in favor of preinstalled > versions, where possible. > > --enable-proper generally switches from bundled to preinstalled libraries. > This review only implements this preinstalled library usage on LevelDB. For > using the preinstalled LevelDB from a location that is not part of the > standard include and linker paths, you may specify --with-leveldb=PREFIX_PATH. > > If --enable-proper is supplied, the configuration phase will attempt to > locate the needed headers as well as the library itself. > > If --enable-proper is not supplied, the bundled library is built and used. > > NOTE: Subsequent review requests for other bundled libraries will follow as > soon as this implementation has been accepted. > > > Diffs > ----- > > 3rdparty/Makefile.am 23ff1fa > configure.ac 9a6de87 > src/Makefile.am 0775a0d > src/python/setup.py.in 02f00ef > > Diff: https://reviews.apache.org/r/18957/diff/ > > > Testing > ------- > > ../configure > make check > > installed leveldb in custom location > ../configure --enable-proper --with-leveldb=/CUSTOM_LOCATION > make check > > installed leveldb in common location > ../configure --enable-proper > make check > > > Thanks, > > Till Toenshoff > >
