> On March 17, 2014, 4:07 p.m., Timothy St. Clair wrote: > > configure.ac, line 250 > > <https://reviews.apache.org/r/18957/diff/2/?file=522715#file522715line250> > > > > Given that this block has the potential for becoming large it may be > > easier to read using 'if test' vs. AS_IF around 'enable_proper'
Well, there is a TODO in our configure.ac that clearly suggests using AS_IF instead of shell-style if's. Personally, I got used to using and reading AS_IFs and prefer them. However, since Adam and you prefer shell-style ifs and since most of the bigger if-clauses are done shell-style, I guess it is for the greater good if I adapt. > On March 17, 2014, 4:07 p.m., Timothy St. Clair wrote: > > configure.ac, line 263 > > <https://reviews.apache.org/r/18957/diff/2/?file=522715#file522715line263> > > > > I'm not certain the -lleveldb flag needs to be applied to all, or > > whether we can call out -lleveldb where needed? Previously, the linkage of > > .a's automatically did incremental, but if linking system .so's this could > > cause unused linkage on executable(s) that didn't actually use the library. It wont make much difference in the results (linker will only bind if missing symbols are resolved). However, it will possibly increase build-time if those flag-extensions are used globally - so I adapted. - Till ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18957/#review37383 ----------------------------------------------------------- On March 17, 2014, 7:51 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18957/ > ----------------------------------------------------------- > > (Updated March 17, 2014, 7:51 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Bugs: MESOS-1071 > https://issues.apache.org/jira/browse/MESOS-1071 > > > Repository: mesos-git > > > Description > ------- > > Allows preventing the use of bundled libraries in favor of preinstalled > versions, where possible. > > --enable-proper generally switches from bundled to preinstalled libraries. > This review only implements this preinstalled library usage on LevelDB. For > using the preinstalled LevelDB from a location that is not part of the > standard include and linker paths, you may specify --with-leveldb=PREFIX_PATH. > > If --enable-proper is supplied, the configuration phase will attempt to > locate the needed headers as well as the library itself. > > If --enable-proper is not supplied, the bundled library is built and used. > > NOTE: Subsequent review requests for other bundled libraries will follow as > soon as this implementation has been accepted. > > > Diffs > ----- > > 3rdparty/Makefile.am 23ff1fa > configure.ac 9a6de87 > src/Makefile.am 0775a0d > src/python/setup.py.in 02f00ef > > Diff: https://reviews.apache.org/r/18957/diff/ > > > Testing > ------- > > ../configure > make check > > installed leveldb in custom location > ../configure --enable-proper --with-leveldb=/CUSTOM_LOCATION > make check > > installed leveldb in common location > ../configure --enable-proper > make check > > > Thanks, > > Till Toenshoff > >
