----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26859/#review57763 -----------------------------------------------------------
Great job! src/master/master.cpp <https://reviews.apache.org/r/26859/#comment98637> Should this really be a CHECK? What happens if an authenticatee (e.g. slave) tries to authenticate with a master not configured for authentication? src/master/master.cpp <https://reviews.apache.org/r/26859/#comment98638> Would there be any problem creating thousands of instances of the same module, one for each authentication? This doesn't actually load the library each time, right? - Adam B On Oct. 21, 2014, 6:01 a.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26859/ > ----------------------------------------------------------- > > (Updated Oct. 21, 2014, 6:01 a.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone. > > > Bugs: MESOS-1889 > https://issues.apache.org/jira/browse/MESOS-1889 > > > Repository: mesos-git > > > Description > ------- > > see summary. > > > Diffs > ----- > > src/master/flags.hpp 9d06856 > src/master/master.hpp 14f1d0f > src/master/master.cpp 0a5c9a3 > > Diff: https://reviews.apache.org/r/26859/diff/ > > > Testing > ------- > > make check > > NOTE all three CRAM-MD5 authenticator module related RRs need to get applied > before running make check. > > > Thanks, > > Till Toenshoff > >
