> On Oct. 22, 2014, 7:01 a.m., Adam B wrote:
> > src/master/master.cpp, line 3803
> > <https://reviews.apache.org/r/26859/diff/2/?file=727115#file727115line3803>
> >
> > Would there be any problem creating thousands of instances of the same
> > module, one for each authentication? This doesn't actually load the library
> > each time, right?
Correct, it does not. A module create is simply invoking the factory method for
the specific module class -- e.g. src/examples/test_authenticator_module.cpp:
static Authenticator* createCRAMMD5Authenticator(const Parameters& parameters)
{
return new mesos::internal::sasl::CRAMMD5Authenticator();
}
The actual dlopen is triggered within src/master/main.cpp, via
ModuleManager::load.
- Till
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26859/#review57763
-----------------------------------------------------------
On Oct. 21, 2014, 1:01 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26859/
> -----------------------------------------------------------
>
> (Updated Oct. 21, 2014, 1:01 p.m.)
>
>
> Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone.
>
>
> Bugs: MESOS-1889
> https://issues.apache.org/jira/browse/MESOS-1889
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> src/master/flags.hpp 9d06856
> src/master/master.hpp 14f1d0f
> src/master/master.cpp 0a5c9a3
>
> Diff: https://reviews.apache.org/r/26859/diff/
>
>
> Testing
> -------
>
> make check
>
> NOTE all three CRAM-MD5 authenticator module related RRs need to get applied
> before running make check.
>
>
> Thanks,
>
> Till Toenshoff
>
>
