----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26859/#review57845 -----------------------------------------------------------
src/master/flags.hpp <https://reviews.apache.org/r/26859/#comment98718> I thought the default is going to be cram-md5 to make it backwards compatible? src/master/master.cpp <https://reviews.apache.org/r/26859/#comment98720> +1 This should not be a CHECK. Also, the module name should be extracted out in initialize() and not here. - Vinod Kone On Oct. 21, 2014, 1:01 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26859/ > ----------------------------------------------------------- > > (Updated Oct. 21, 2014, 1:01 p.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone. > > > Bugs: MESOS-1889 > https://issues.apache.org/jira/browse/MESOS-1889 > > > Repository: mesos-git > > > Description > ------- > > see summary. > > > Diffs > ----- > > src/master/flags.hpp 9d06856 > src/master/master.hpp 14f1d0f > src/master/master.cpp 0a5c9a3 > > Diff: https://reviews.apache.org/r/26859/diff/ > > > Testing > ------- > > make check > > NOTE all three CRAM-MD5 authenticator module related RRs need to get applied > before running make check. > > > Thanks, > > Till Toenshoff > >
