[GitHub] metamodel pull request #205: close ResultSet after get result

[kaspersorensen]

Github user kaspersorensen commented on a diff in the pull request:

    https://github.com/apache/metamodel/pull/205#discussion_r245492826
  
    --- Diff: jdbc/src/main/java/org/apache/metamodel/jdbc/JdbcDataContext.java 
---
    @@ -289,6 +289,13 @@ private boolean usesCatalogsAsSchemas(DatabaseMetaData 
metaData) {
             } catch (SQLException e) {
                 throw JdbcUtils.wrapException(e, "retrieve schema and catalog 
metadata", JdbcActionType.METADATA);
             } finally {
    +            if(rs != null) {
    --- End diff --
    
    Very minor, but our code style conventions are to have a space after `if` 
and before the `(`


---