Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/205#discussion_r245492854
--- Diff: jdbc/src/main/java/org/apache/metamodel/jdbc/JdbcDataContext.java
---
@@ -289,6 +289,13 @@ private boolean usesCatalogsAsSchemas(DatabaseMetaData
metaData) {
} catch (SQLException e) {
throw JdbcUtils.wrapException(e, "retrieve schema and catalog
metadata", JdbcActionType.METADATA);
} finally {
+ if(rs != null) {
--- End diff --
Actually, even better would be for you to just use
`FileHelper.safeClose(rs);` instead of this if + try-catch stuff.
---
