[GitHub] metamodel pull request #205: close ResultSet after get result

[kaspersorensen]

Github user kaspersorensen commented on a diff in the pull request:

    https://github.com/apache/metamodel/pull/205#discussion_r245515460
  
    --- Diff: jdbc/src/main/java/org/apache/metamodel/jdbc/JdbcDataContext.java 
---
    @@ -797,7 +800,7 @@ public String getIdentifierQuoteString() {
                         logger.debug("Found schemaName: {}", schemaName);
                         result.add(schemaName);
                     }
    -                rs.close();
    +                FileHelper.safeClose(rs);
    --- End diff --
    
    This should also be in a finally block.


---