Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/205#discussion_r245492858
--- Diff: jdbc/src/main/java/org/apache/metamodel/jdbc/JdbcDataContext.java
---
@@ -580,6 +587,13 @@ public void close(Connection connection, ResultSet rs,
Statement st) {
} catch (SQLException e) {
logger.error("Error retrieving catalog metadata", e);
} finally {
+ if(rs != null){
+ try {
+ rs.close();
--- End diff --
Use `FileHelper.safeClose(rs);`---
