[GitHub] metamodel pull request #205: close ResultSet after get result

[kaspersorensen]

Github user kaspersorensen commented on a diff in the pull request:

    https://github.com/apache/metamodel/pull/205#discussion_r245515445
  
    --- Diff: jdbc/src/main/java/org/apache/metamodel/jdbc/JdbcDataContext.java 
---
    @@ -756,6 +758,7 @@ private String findDefaultSchema(final String 
defaultName, final List<String> sc
             while (rs.next()) {
                 schemas.add(rs.getString("TABLE_SCHEM"));
             }
    +        FileHelper.safeClose(rs);
    --- End diff --
    
    This should be in a finally block that you create once you have the 
ResultSet:
    
    ```
    ResultSet rs = ...
    try {
      ...
    } finally {
      FileHelper.safeClose(rs);
    }
    ```


---