Github user q977734161 commented on a diff in the pull request: https://github.com/apache/metamodel/pull/205#discussion_r245537364 --- Diff: jdbc/src/main/java/org/apache/metamodel/jdbc/JdbcDataContext.java --- @@ -289,6 +289,7 @@ private boolean usesCatalogsAsSchemas(DatabaseMetaData metaData) { } catch (SQLException e) { throw JdbcUtils.wrapException(e, "retrieve schema and catalog metadata", JdbcActionType.METADATA); } finally { + FileHelper.safeClose(rs); close(null); --- End diff -- ok.I will improve the code.Thanks for review.
---