>From a library-user (i.e. developer) standpoint: don't include the external jars in the binary distro.
1) It is a lot of bandwidth for stuff I have already.
2) It is a lot, in a project as wide as MyFaces.
3) It is confusing, at least if the jar's do not contain the exact version number in the filename (maven-style).
4) You cannot include some jar's for license reasons (jsp api, e.g., I seem to recall) anyway.
This also means that the extensive dependency documentation is needed also outside the build script. Like in a POM.
On 27 Jun 2005, at 20:37, Bruno Aranda wrote:
I do agree with all your points. The source distro should not include<x-tad-smaller>Met vriendelijke groeten,
the jars. IMO, that distro is a snapshot of the sources as we can find
them using SVN. No more, no less.
I should include the dependencies in both the binary distro and in the examples.
Either of the three possibilities allow to have a working myfaces
distro. For the sources, you build them and download the dependencies
using the script; for the binary, no build is needed and the
dependencies are provided; and, of course, the examples should work
out-of-the-box, and, if possible, provide versions of the examples for
different configurations (different server version, etc...),
Regards,
Bruno
2005/6/27, Sean Schofield <[EMAIL PROTECTED]>:
I've been thinking about the JAR files in the source distribution. To
me it makes no sense to include them in the source distro. (I don't
believe we have done that up to this point either so this would not be
a change for MyFaces.)
If someone wants to build from the source distro they can follow the
standard build procedure. The depencies are only a few keystrokes
away using ant (or eventually Maven.)
For the binary distro I guess I am +1 for including them there. You
can quickly copy the ones you need to your server/lib or whatever or
you can ignore them. No harm done either way. For the examples
distro (nightly build only) I think we definitely include them. IMO
those should be runable in a default Tomcat install just by dropping
in the WAR.
sean
On 6/27/05, Sean Schofield <[EMAIL PROTECTED]> wrote:
As for removing the jars from SVN, I think we should consider this
matter closed. Its a good idea for several reasons which Craig,
Martin and others have articulated quite clearly. Not only will this
save bandwith (and therefore money) for the ASF, but it brings us into
compliance with the standard by which other ASF projects do things.
When possible, the various ASF projects should try to do things in a
similar fashion. Regardless of how one might decide to do things in
their corporate environment, ASF has its own way of doing things.
MyFaces should comply with the formal and informal practices of the
other projects whenever there is not a compelling reason to deviate
from those norms.
There is still the matter of including jars in the binary distro, etc.
where I can see advantages and disadvantages to the two approaches.
But as far as jars in SVN are concerned, it seems quite clear that
this practice should end.
sean
On 6/27/05, Sean Schofield <[EMAIL PROTECTED]> wrote:
And we're working on just such a list of the dependencies. That is
one benefit of moving the jars out of SVN. I took the approach that
the Struts build uses. The build script clearly lists the depencies
and the version numbers required.
Of course we could have that without removing the jars from SVN too.
But its 100% essential if we don't supply the jars and so now we have
it. Both sides should be happy on this point :-)
sean
On 6/27/05, ir. ing. Jan Dockx <[EMAIL PROTECTED]> wrote:
On 25 Jun 2005, at 20:43, Craig McClanahan wrote:
For the record, I am absolutely and totally -1 on including JAR files
in the source code repository of any Apache project that I work on.
Including them in a binary distribution, of course, is a totally
different animal.
Craig
Even then. (see previous post). In my opinion (for as much as that of a
user counts), only end-user products should contain all dependencies.
Libraries should never, but instead list the dependencies with all
needed information, including what each dependency is needed for.
Met vriendelijke groeten,
Jan Dockx
PeopleWare NV - Head Office
Cdt.Weynsstraat 85
B-2660 Hoboken
Tel: +32 3 448.33.38
Fax: +32 3 448.32.66
PeopleWare NV - Branch Office Geel
Kleinhoefstraat 5
B-2440 Geel
Tel: +32 14 57.00.90
Fax: +32 14 58.13.25
http://www.peopleware.be/
http://www.mobileware.be/
Jan Dockx
</x-tad-smaller><x-tad-smaller>
PeopleWare NV - Head Office</x-tad-smaller><x-tad-smaller>
Cdt.Weynsstraat 85
B-2660 Hoboken
Tel: +32 3 448.33.38
Fax: +32 3 448.32.66 </x-tad-smaller><x-tad-bigger>
</x-tad-bigger><x-tad-smaller>
PeopleWare NV - Branch Office Geel</x-tad-smaller><x-tad-smaller>
Kleinhoefstraat 5
B-2440 Geel
Tel: +32 14 57.00.90
Fax: +32 14 58.13.25</x-tad-smaller><x-tad-bigger>
</x-tad-bigger><x-tad-smaller>
http://www.peopleware.be/
</x-tad-smaller><x-tad-smaller>http://www.mobileware.be/</x-tad-smaller>
smime.p7s
Description: S/MIME cryptographic signature
