Doh!! Mark, that is an awesome catch. That's a relatively new sub-project and I didn't catch the missing listence files. I'll change those tonight and send out a new vote email.
Scott Sent from my iPhone On Sep 19, 2011, at 2:51 AM, Mark Struberg <[email protected]> wrote: > Hi Scott! > > I'm sorry, but I fear I have to veto with a -1. > > trinidad-components-showcase.war (WAR!) > > has no NOTICE nor LICENSE files I could find. > > I know we shipped lots of WAR files in the past without those, but I only > recently became aware of this problem in OpenWebBeans where I had to re-roll > my release too. > > This can easily get fixed by doing some packaging tricks > Please see the maven-war-plugin config of the OWB samples > > https://svn.apache.org/repos/asf/openwebbeans/trunk/samples/pom.xml > > The important part is > <webResources> <resource> <directory>.</directory> > <targetPath>META-INF</targetPath> <includes> <include>LICENSE</include> > <include>NOTICE</include> </includes> </resource> </webResources> > > Otherwise the release looks fine so far. > > > txs LieGrue, > strub > > > > > ----- Original Message ----- >> From: Scott O'Bryan <[email protected]> >> To: [email protected] >> Cc: >> Sent: Saturday, September 17, 2011 2:38 AM >> Subject: [VOTE] Release of Trinidad 2.0.1 >> >> Hi Everyone, >> >> I was running the tasks needed to get the Trinidad 2.0.1 release out and now >> I >> need a vote as to whether everything looks good or not. I have committed >> most >> of the most recent submitted patches and things look to be fairly stable. >> There >> are a few patches outstanding, but I wanted to put those into trunk so that >> they >> can get some more testing. >> >> Therefore, I would like to ask for a vote on this release. All of the >> following >> should be ready for review: >> >> * The generated repository and assembly artifacts [1] >> * The generated source archive [2] >> * The updated svn repository [3] >> >> Please review the artifacts and vote according to the following: >> >> ------------------------------------------------ >> [ ] +1 for community members who have reviewed the bits >> [ ] +0 >> [ ] -1 for fatal flaws that should cause these bits not to be released, >> and why.............. >> ------------------------------------------------ >> >> This vote will remain open for at least 72 hours. >> >> Thanks, >> Scott O'Bryan >> >> [1] https://repository.apache.org/content/repositories/orgapachemyfaces-072 >> [2] >> https://repository.apache.org/content/repositories/orgapachemyfaces-072/org/apache/myfaces/trinidad/trinidad/2.0.1/trinidad-2.0.1-source-release.zip >> [3] https://svn.apache.org/repos/asf/myfaces/trinidad/tags/trinidad-2.0.1 >>
