On Mon, 24 Oct 2022 at 11:50, Geertjan Wielenga <geert...@apache.org> wrote: > Right now, when we build NetBeans, we’re using the javac from the JDK that > we’re using to do the build — so that we’re dependent on the JDK team, > which can decide to drop features. > > If, instead, we were to set the compiler in NetBeans the build script, to > nb-javac, which is available on Maven Central and is compatible with javac, > and is used as part of NetBeans already at runtime, and runs on JDK 8 or > later — unlike javac which is tied to the JDK against which we’re doing the > build — we would be even more independent and we’d be able to build for > future JDKs, we would not have a need for a minimum JDK. > > The module definition in project.properties of each module could define its > javac target version. We could have a module using virtual threads, set to > target 19, where it would be disable if not run on JDK 19. > > The Disco module, right now, cannot be compiled on JDK 8 because it sets > its target to 11, though if nb-javac were used during the build, because > nb-javac right now supports everything up to 19. > > So, switching to nb-javac sounds like a sensible thing — are there any > objections, Jaroslav has a pull request.
Multiple people have expressed massive reservations on this already. Michael expressed a -0.99 already. Given code changes are really +1 or -1 anyway, I'll lend the -0.01 until his and other reservations are adequately considered at least. Also, the Disco module wasn't updated to require compiling on JDK 11 until we had already made a decision to drop support for compiling on JDK 8. Why is bringing JDK 8 compilation back at all relevant now? And finally, what is the long term future of nb-javac and is its long term development sustainable and responsive to our needs? Because that can't be here, and it's not currently in the Oracle repository or Maven namespace that was originally proposed here and to ASF legal either. Best wishes, Neil --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org For additional commands, e-mail: dev-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
