Could I suggest a tweak to the job config for the job incubator-netbeans-release?
It seems that it's triggered to build on every commit? I assume there's other jobs checking this? if not then how about having a CI related job, i.e. one that builds on every commit(and maybe nightly releases when/if we hook that up again) and then another one just for releases? This way we can then start adding logic, like creating a tag in GIT for every build and only executing that job when preparing a release - since it won't be building so often we won't get lost in tags. There might be other logic we include here as well, maybe relating to signatures, automating the rest of the release process... Regards John On 8 February 2018 at 22:12, Geertjan Wielenga < geertjan.wiele...@googlemail.com> wrote: > Yup. Thanks. We’re learning — and I’m less smart than Jan Lahoda when it > comes to producing releases, though these gentle slaps on the wrist are > great for building up knowledge in understanding the ins and outs of the > Apache Way. :-) > > Gj > > On Thursday, February 8, 2018, Ate Douma <a...@douma.nu> wrote: > > > > > > > On 2018-02-08 22:48, Ate Douma wrote: > > > >> On 2018-02-08 22:22, Geertjan Wielenga wrote: > >> > What are the differences? > >> > >> Just as an example, check the README.md files. > >> In git []1] it is more than a month old and not including the recent > >> changes, like mentioning the rat-exclusions.txt, etc. > >> > >> [1] https://github.com/apache/incubator-netbeans/blob/9.0-beta- > >> rc3/README.md > >> > >> > > >> > I did make the tag shortly after the source distribution download — > >> but not > >> > very long after. > >> > >> Then I think that tag was created incorrectly. Looks like you tagged an > >> outdated clone or checkout. > >> > >> > > >> > If there’s a problem here, the fault is mine personally. But, so, > what > >> are > >> > the differences (and how do you identify that)? > >> > >> Too much to list here, but trivially to check: just diff/compare both > >> source trees locally (I tend to use/like Meld for these kind of things). > >> > >> For ASF the vote concerns the source dist *you* prepared, so I'm > >> proceeding with verifying and voting on that. > >> But it also should be traceable what the origin is of that source dist. > >> > >> If you can recall at which time you created that source dist, and > >> assuming that was against master (?), it might be not difficult to > >> determine what the HEAD hash was at that time. > >> Then, after making sure that source dist and that git state for that > >> hash indeed are equal, I would suggest to drop and recreate the rc3 tag > >> so that it actually matches the source dist. > >> > > > > A common practice/rule applied by other ASF projects is to always also > > mention the specific git hash upon which the release candidate is based, > > besides the tag. That possibly would have prevented this, and/or easier > > to check/fix. > > > > > >> I'm fine to +1 the current vote (if/when I'm done and don't find any > >> blockers, and it looks pretty good to me so far), but IMO the tag needs > >> to be fixed before moving this vote to the IPMC. > >> > >> Ate > >> > >> > > >> > Gj > >> > > >> > On Thursday, February 8, 2018, Ate Douma <a...@douma.nu> wrote: > >> > > >> >> Just a quick first check/heads-up, I'm just starting the review. > >> >> > >> >> Surprisingly, the source distribution download is clearly *not* > >> >> based on the 9.0-beta-rc3 tag in git! > >> >> > >> >> I checkout the git tag and compared it with the contents of the > source > >> >> zip and there is a huge amount of differences. > >> >> > >> >> From which 'tag' was the source zip created from, possibly the tag > >> was > >> >> created wrong? > >> >> > >> >> For now I'll proceed with checking the sources from the zip. > >> >> > >> >> Ate > >> >> > >> >> On 2018-02-08 16:46, Ate Douma wrote: > >> >> > >> >>> On 2018-02-07 17:27, Ate Douma wrote: > >> >>> > >> >>>> I've been in a similar situation as Bertrand, d2d job obligations > >> >>>> claimed my whole day, no time left. > >> >>>> I'll try again tomorrow before EOB. > >> >>>> > >> >>> > >> >>> Sorry, won't make it anymore before EOB (CET) but will try to pick > >> >>> this up this evening after diner. > >> >>> > >> >>> Ate > >> >>> > >> >>> > >> >>>> On 2018-02-07 16:45, Geertjan Wielenga wrote: > >> >>>> > >> >>>>> We can wait until tomorrow morning hopefully! > >> >>>>> > >> >>>> > >> >>>> The 72h duration for a vote is a minimum, not a maximum > >> >>>> > >> >>>> Ate > >> >>>> > >> >>>> > >> >>>>> Gj > >> >>>>> > >> >>>>> On Wednesday, February 7, 2018, Bertrand Delacretaz < > >> >>>>> bdelacre...@apache.org> > >> >>>>> wrote: > >> >>>>> > >> >>>>> On Tue, Feb 6, 2018 at 2:55 PM, Bertrand Delacretaz > >> >>>>>> <bdelacre...@apache.org> wrote: > >> >>>>>> > >> >>>>>>> ...That should work for me, it's on my list for tomorrow... > >> >>>>>>> > >> >>>>>> > >> >>>>>> There's been competition for slots on that list > >> >>>>>> > >> >>>>>> It looks like I won't be able to review the release today, > either > >> wait > >> >>>>>> for it to happen tomorrow morning hopefully, or go ahead with > the > >> >>>>>> Incubator PMC vote and I'll review there. > >> >>>>>> > >> >>>>>> -Bertrand > >> >>>>>> > >> >>>>>> ------------------------------------------------------------ > >> --------- > >> >>>>>> To unsubscribe, e-mail: dev-unsubscribe@netbeans. > >> incubator.apache.org > >> >>>>>> For additional commands, e-mail: dev-help@netbeans.incubator. > >> >>>>>> apache.org > >> >>>>>> > >> >>>>>> For further information about the NetBeans mailing lists, visit: > >> >>>>>> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing > >> +lists > >> >>>>>> > >> >>>>>> > >> >>>>>> > >> >>>>>> > >> >>>>>> > >> >>>>> > >> >> ------------------------------------------------------------ > --------- > >> >> To unsubscribe, e-mail: dev-unsubscribe@netbeans. > incubator.apache.org > >> >> For additional commands, e-mail: dev-help@netbeans.incubator. > >> apache.org > >> >> > >> >> For further information about the NetBeans mailing lists, visit: > >> >> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists > >> >> > >> >> > >> >> > >> >> > >> > > >> > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@netbeans.incubator.apache.org > > For additional commands, e-mail: dev-h...@netbeans.incubator.apache.org > > > > For further information about the NetBeans mailing lists, visit: > > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists > > > > > > > > >
